Re: [Valgrind-developers] Fixing bug 69616

[Tom H. <th...@cy...>]

In message <Pin...@re...>
        Nicholas Nethercote <nj...@ca...> wrote:

> It looks like upcoming glibc 2.3.3 will use a different version of
> pthreadtypes.h.  This caused 69616 for Gentoo users who get a cutting-edge
> version, which breaks Valgrind.  Note that this bug has 165 votes;  the
> next highest one has 28 votes.
>
> I wrote a patch that seems to fix the problem.  Basically, we were using
> the LinuxThreads pthread structures, so when glibc changed the structures,
> things broke.  I've just introduced a level of indirection -- the patch
> uses the LinuxThreads structure layouts, but gives them a different name,
> and all the original types get cast to these differently-named types
> before doing anything.
>
> But I'm not totally certain about it.  For example, for some structure
> fields I've used slightly different types to the LinuxThread structures.
> And I'm not very familiar with the pthreads code in general.  I'd
> appreciate someone else looking at the patch.  Thanks.

I'm not hugely familiar with LinuxThreads or NPTL but the changes look
right to me, and the structures all seem to match sufficiently to work
correctly.

Tom

-- 
Tom Hughes (th...@cy...)
Software Engineer, Cyberscience Corporation
http://www.cyberscience.com/