|
From: Nicholas N. <nj...@ca...> - 2004-02-12 14:46:45
|
On Thu, 12 Feb 2004, Nicholas Nethercote wrote: > Heroic patch from Tom Hughes: > > This patch adds translation tests for most of the basic x86 instructions and > fixes a few missing/broken instructions to work properly. Tom, can you explain exactly what your insn_*.c tests do? AFAICT, they test every single instruction in some way, but I'd like to know exactly what is being tested. (Great idea, BTW, thanks for putting the effort into the scripts to generate the test cases... although I wonder if the C could be more succinct, eg. by using macros? The five generated .c files take up about 2MB :) If it's really thorough, this seems like a reasonable replacement for the lost --stop-after flag... if we can plausibly test every instruction sufficiently(*), we can be certain the VCPU is correct. (*) The definition of 'sufficiently' is crucial here... I'm not quite sure what it means. N |