Re: [Valgrind-developers] Merging stage2.c and vg_main.c

[Nicholas N. <nj...@ca...>]

On Fri, 23 Jan 2004, Tom Hughes wrote:

> > I've made quite a few more simplifications, and merged together various
> > steps that were closely related;  it's looking relatively clean, now.  I
> > would like someone else to confirm it works on their machine before I
> > commit it.
>
> It seems largely OK to me. The main problem is that it doesn't compile
> due to the VGP_PUSHCC(VgpStartup) and VGP_POPCC(VgpStartup) calls in
> vg_main.c as VgpStartup doesn't seem to exist. Once I commented those
> out it built and ran.

Whoops, must edit vg_skin.h.base, not vg_skin.h.

> The only other thing I noticed is that it is printing a message
> whenever it sees a --tool:option=value type switch - did you mean
> to leave that in or is it just some debugging?

Just debugging, will remove.

I'll update the patch on my website.

Thanks.

N