Re: [Valgrind-developers] Merging stage2.c and vg_main.c

[Tom H. <th...@cy...>]

In message <Pin...@ye...>
        Nicholas Nethercote <nj...@ca...> wrote:

> I've updated the patch, it's at:
>
>   www.cl.cam.ac.uk/~njn25/startup-merge.patch2
>
> I've made quite a few more simplifications, and merged together various
> steps that were closely related;  it's looking relatively clean, now.  I
> would like someone else to confirm it works on their machine before I
> commit it.

It seems largely OK to me. The main problem is that it doesn't compile
due to the VGP_PUSHCC(VgpStartup) and VGP_POPCC(VgpStartup) calls in
vg_main.c as VgpStartup doesn't seem to exist. Once I commented those
out it built and ran.

The only other thing I noticed is that it is printing a message
whenever it sees a --tool:option=value type switch - did you mean
to leave that in or is it just some debugging?

Tom

-- 
Tom Hughes (th...@cy...)
Software Engineer, Cyberscience Corporation
http://www.cyberscience.com/