Re: [Valgrind-developers] tool-specific CLOs

[Doug R. <df...@nl...>]

On Fri, 2004-01-09 at 16:20, Nicholas Nethercote wrote:
> On Thu, 8 Jan 2004, Nicholas Nethercote wrote:
> 
> > I'm currently looking in three places:
> >
> >  1.  ~/.valgrindrc
> >  2.  VALGRIND_OPTS
> >  3.  ./.valgrindrc
> >
> > Args are added in that order, the idea being that more 'local' args are
> > added later, to override less local ones.  (1) and (2) could be swapped,
> > but (3) should definitely be last, as it's clearly the most local.
> 
> I've swapped, giving:
> 
>   1.  VALGRIND_OPTS
>   2.  ~/.valgrindrc
>   3.  ./.valgrindrc
> 
> Diff is attached, feedback welcome.  I hope the way I mmap'd in the .rc
> files and didn't munmap them is reasonable.
> 
> I think this also fixes bug 71126, thanks to Tom for his patch.

This will have problems if the file is exactly getpagesize() bytes long
since the mmap'ed image won't be null terminated.