|
From: Julian S. <js...@ac...> - 2004-01-04 23:08:40
|
CVS commit by jseward:
In the fast sanity check for these tools which use shadow memory,
remove the test that the first page of memory is inaccessible. This
is now getting in the way.
Fixes #69886.
M +2 -15 addrcheck/ac_main.c 1.58
M +2 -16 helgrind/hg_main.c 1.71
M +2 -15 memcheck/mc_main.c 1.45
--- valgrind/addrcheck/ac_main.c #1.57:1.58
@@ -1143,21 +1143,8 @@ static void ac_detect_memory_leaks ( voi
------------------------------------------------------------------ */
-/* Check that nobody has spuriously claimed that the first or last 16
- pages (64 KB) of address space have become accessible. Failure of
- the following do not per se indicate an internal consistency
- problem, but they are so likely to that we really want to know
- about it if so. */
-
Bool SK_(cheap_sanity_check) ( void )
{
- if (IS_DISTINGUISHED_SM(primary_map[0])
- /* kludge: kernel drops a page up at top of address range for
- magic "optimized syscalls", so we can no longer check the
- highest page */
- /* && IS_DISTINGUISHED_SM(primary_map[65535]) */
- )
+ /* nothing useful we can rapidly check */
return True;
- else
- return False;
}
--- valgrind/helgrind/hg_main.c #1.70:1.71
@@ -2001,21 +2001,8 @@ void* SK_(realloc) ( void* p, Int new_si
/*--------------------------------------------------------------*/
-/* Check that nobody has spuriously claimed that the first or last 16
- pages (64 KB) of address space have become accessible. Failure of
- the following do not per se indicate an internal consistency
- problem, but they are so likely to that we really want to know
- about it if so. */
-
Bool SK_(cheap_sanity_check) ( void )
{
- if (VGE_IS_DISTINGUISHED_SM(primary_map[0])
- /* kludge: kernel drops a page up at top of address range for
- magic "optimized syscalls", so we can no longer check the
- highest page */
- /* && VGE_IS_DISTINGUISHED_SM(primary_map[65535]) */
- )
+ /* nothing useful we can rapidly check */
return True;
- else
- return False;
}
--- valgrind/memcheck/mc_main.c #1.44:1.45
@@ -1469,21 +1469,8 @@ void MC_(detect_memory_leaks) ( void )
------------------------------------------------------------------ */
-/* Check that nobody has spuriously claimed that the first or last 16
- pages (64 KB) of address space have become accessible. Failure of
- the following do not per se indicate an internal consistency
- problem, but they are so likely to that we really want to know
- about it if so. */
-
Bool SK_(cheap_sanity_check) ( void )
{
- if (IS_DISTINGUISHED_SM(primary_map[0])
- /* kludge: kernel drops a page up at top of address range for
- magic "optimized syscalls", so we can no longer check the
- highest page */
- /* && IS_DISTINGUISHED_SM(primary_map[65535]) */
- )
+ /* nothing useful we can rapidly check */
return True;
- else
- return False;
}
|