|
From: Doug R. <df...@nl...> - 2003-12-28 14:43:25
|
On Sun, 2003-12-28 at 14:32, Julian Seward wrote: > On Saturday 27 December 2003 17:02, Dirk Mueller wrote: > > > > Most of the > > > syscall hairy bits should also help to get NetBSD and OpenBSD going too. > > > I have ended up with a bit of an ifdef tangle in a few places but that > > > might be best managed by simply forking a few of the source files > > > (vg_kerneliface.h, vg_syscalls.c and similar). My patch is currently > > > about 130k (as a unified diff against 2.1.0. > > > > Yes. ideally we should start with a directory structure and move the linux > > specific files in a subdir, and fork them for other operating systems or > > architectures. > > I agree with Dirk. Ports are of course a good thing, but we need > structure. Can you make a proposal for how to adjust the directory > structure so as to accommodate these x86 unixes as cleanly/modularly > as possible? Then we can think about adding the FreeBSD stuff to > the cvs. Solaris-x86 is another potential target, btw. It seems to me that the simplest approach would be to move the really os-dependant files into a subdir of coregrind (e.g. coregrind/linux). Files which seem to be in this category are vg_libpthread*.c, vg_procselfmaps.c, vg_proxylwp.c, vg_signals.c (maybe), vg_syscall.S, vg_syscalls.c, vg_unistd.h, vg_unsafe.h. Similarly in include, vg_kerneliface.h would move to include/linux/vg_kerneliface.h. > Thanks, > > J > > > ------------------------------------------------------- > This SF.net email is sponsored by: IBM Linux Tutorials. > Become an expert in LINUX or just sharpen your skills. Sign up for IBM's > Free Linux Tutorials. Learn everything from the bash shell to sys admin. > Click now! http://ads.osdn.com/?ad_id=1278&alloc_id=3371&op=click > _______________________________________________ > Valgrind-developers mailing list > Val...@li... > https://lists.sourceforge.net/lists/listinfo/valgrind-developers |