|
From: Jeremy F. <je...@go...> - 2003-11-20 17:29:22
|
On Thu, 2003-11-20 at 01:32, Nicholas Nethercote wrote: > Preferably the replacement warning would fit on one line, which the one > above doesn't. The similar warning "warning: call to foo() IGNORED" is > short and easily understandable... are there any simple English words that > mean "kind of done, but not properly"? Maybe "faked"? "Bluffed"? Or > maybe it can't be explained clearly in one word. > > Or maybe two lines isn't so bad, eg: > > warning: Valgrind's version of foo() is incomplete; > your program may misbehave as a result > > warning: Valgrind's version of foo() does nothing; > your program may misbehave as a result > > Comments? Well, for many of the functions they don't have user-visible side-effects anyway, so we should just be silent about them. pthread_cond_destroy being a good example - there's nothing it need to do, so doing nothing is perfectly reasonable. We should only print a message if we're not doing something, and that something has some kind of client-visible effect. J |