|
From: Jim M. <ji...@me...> - 2003-11-17 19:08:56
|
Nicholas Nethercote <nj...@ca...> wrote:
...
> @@ -1102,7 +1102,7 @@ static void process_cmd_line_options ( v
> /* So far we should be still attached to stderr, so we can show on
> the terminal any problems to do with processing command line
> opts. */
> - vg_assert(VG_(clo_logfile_fd) == 2 /* stderr */);
> + vg_assert(VG_(clo_logfile_fd) == 1 /* stderr */);
> vg_assert(VG_(logging_to_filedes) == True);
>
> switch (VG_(clo_log_to)) {
You probably already know, and simply prefer to use the hard-coded
literal file numbers, but just in case, ...
it'd make the code a tiny bit more readable to use
STDOUT_FILENO and STDERR_FILENO in place of 1 and 2 respectively.
Then you could get rid of the `/* stderr */' comment that should
(with the above change) read `/* stdout */'.
|