|
From: Nicholas N. <nj...@ca...> - 2003-11-17 17:46:19
|
On Mon, 17 Nov 2003, Andr=E9s Rold=E1n wrote:
> > valgrind --help 2>&1 | more
>
> I know. I'm maintaining valgrind for Debian and there is a rule on
> Debian that says that every large --help message should be on STDOUT
> instead of STDERR.
Oh, right, sorry.
Try the patch below; I've tested it minimally.
N
RCS file: /home/kde/valgrind/coregrind/vg_main.c,v
retrieving revision 1.115
diff -u -3 -p -r1.115 vg_main.c
--- coregrind/vg_main.c 29 Sep 2003 10:56:24 -0000 1.115
+++ coregrind/vg_main.c 17 Nov 2003 17:44:48 -0000
@@ -527,7 +527,7 @@ Bool VG_(clo_trace_children) =3D False;
/* See big comment in vg_include.h for meaning of these three. */
VgLogTo VG_(clo_log_to) =3D VgLogTo_Fd;
-Int VG_(clo_logfile_fd) =3D 2;
+Int VG_(clo_logfile_fd) =3D 1;
Char* VG_(clo_logfile_name) =3D NULL;
Int VG_(clo_input_fd) =3D 0; /* stdin */
@@ -725,7 +725,7 @@ static void process_cmd_line_options ( v
# define ISSPACE(cc) ((cc) =3D=3D ' ' || (cc) =3D=3D '\t' || (cc) =
=3D=3D '\n')
- eventually_logfile_fd =3D VG_(clo_logfile_fd);
+ eventually_logfile_fd =3D 2;
/* Once logging is started, we can safely send messages pertaining
to failures in initialisation. */
@@ -1102,7 +1102,7 @@ static void process_cmd_line_options ( v
/* So far we should be still attached to stderr, so we can show on
the terminal any problems to do with processing command line
opts. */
- vg_assert(VG_(clo_logfile_fd) =3D=3D 2 /* stderr */);
+ vg_assert(VG_(clo_logfile_fd) =3D=3D 1 /* stderr */);
vg_assert(VG_(logging_to_filedes) =3D=3D True);
switch (VG_(clo_log_to)) {
|