[Valgrind-developers] [valgrind] FreeBSD: a bit of cleaning of client stack creation

[Paul F. <pa...@so...>]

https://sourceware.org/cgit/valgrind/commit/?id=7769d95480ec28e2ebcf475d04a5b495d5502e59

commit 7769d95480ec28e2ebcf475d04a5b495d5502e59
Author: Paul Floyd <pj...@wa...>
Date:   Fri Dec 5 21:44:56 2025 +0100

    FreeBSD: a bit of cleaning of client stack creation
    
    Remove some commented out rounding
    Make stringbase point to a word boundary, not one before

Diff:
---
 coregrind/m_initimg/initimg-freebsd.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/coregrind/m_initimg/initimg-freebsd.c b/coregrind/m_initimg/initimg-freebsd.c
index 09f3dda847..cd127736ce 100644
--- a/coregrind/m_initimg/initimg-freebsd.c
+++ b/coregrind/m_initimg/initimg-freebsd.c
@@ -473,17 +473,14 @@ static Addr setup_client_stack(const void*  init_sp,
          break;
       case VKI_AT_CANARYLEN:
          canarylen = cauxv->u.a_val;
-         /*VG_ROUNDUP(stringsize, sizeof(Word));*/
          stringsize += canarylen;
          break;
       case VKI_AT_PAGESIZESLEN:
          pagesizeslen = cauxv->u.a_val;
-         /*VG_ROUNDUP(stringsize, sizeof(Word));*/
          stringsize += pagesizeslen;
          break;
 #if 0
       case VKI_AT_TIMEKEEP:
-         /*VG_ROUNDUP(stringsize, sizeof(Word));*/
          stringsize += sizeof(struct vki_vdso_timehands);
          break;
 #endif
@@ -519,7 +516,7 @@ static Addr setup_client_stack(const void*  init_sp,
    client_SP = VG_ROUNDDN(client_SP, 16); /* make stack 16 byte aligned */
 
    /* base of the string table (aligned) */
-   stringbase = strtab = (HChar *)clstack_end
+   stringbase = strtab = (HChar *)clstack_end + 1
                          - VG_ROUNDUP(stringsize, sizeof(int));
 
    clstack_start = VG_PGROUNDDN(client_SP);