|
From: Nicholas N. <nj...@ca...> - 2003-12-02 03:24:27
|
Hi, We've had a few problems with valgrind -q printing out more things than it should. Basically because it's easy to forget to wrap calls to VG_(message)() inside an "if (VG_(clo_verbosity)...)" condition. I think the way to fix this would be to augment VG_(message)() to take an additional integer parameter, that shows how important the message is. Ie. '0' would be shown even with -q, '1' would be shown normally, '2' with -v, '3' with -v -v. That way you couldn't add a VG_(message)() call without thinking about when it should be shown. Only problem is that the change would be moderately pervasive (I see 379 calls to VG_(message)() -- many of which occur together -- and 58 mentions of VG_(clo_verbosity)), and I don't want to cause merging hassles in people's (esp. Jeremy's) workspaces. Thoughts? N |