Re: [Valgrind-developers] tests/x86_amd64_features.c

[Paul F. <pj...@wa...>]

On 7/23/25 11:53, Florian Krohm wrote:
>
> diff --git a/tests/x86_amd64_features.c b/tests/x86_amd64_features.c
> index 488f155b6..5a95e06df 100644
> --- a/tests/x86_amd64_features.c
> +++ b/tests/x86_amd64_features.c
> @@ -148,7 +148,8 @@ static Bool go(char* cpu)
>     assert( !(cmask != 0 && dmask != 0 && bmask != 0) );
>     assert( !(cmask == 0 && dmask == 0 && bmask == 0) );
>
> -   if (require_amd && !vendorStringEquals("AuthenticAMD"))
> +   if (require_amd && !vendorStringEquals("AuthenticAMD") &&
> +       !vendorStringEquals("GenuineIntel"))
>        return FEATURE_NOT_PRESENT;
>        // regardless of what that feature actually is 


Looks fine, but I don't know what is likely to ever present as neither 
AuthenticAMD nor GenuineIntel.

Cyrix, VIA and Transmeta have all gone. There is one Chinese c86 
manufacturer.


A+

Paul