[Valgrind-developers] tests/x86_amd64_features.c

[Florian K. <fl...@ei...>]

While regtesting a patch for x86 to remove Iop_Clz32 (BZ 507033) I noticed that 
the testcase none/tests/x86/lzcnt32 was not executed due to lack of required 
prereqs. This of course is *the* interesting testcase here.

The reason it's not executed is because tests/x86_amd64_features.c has this:

    if (require_amd && !vendorStringEquals("AuthenticAMD"))
       return FEATURE_NOT_PRESENT;

My laptop identifies itself as "GenuineIntel". Therefore I propose the regtested 
patch below. Anybody sees a problem with that?

Thanks,
    Florian


diff --git a/tests/x86_amd64_features.c b/tests/x86_amd64_features.c
index 488f155b6..5a95e06df 100644
--- a/tests/x86_amd64_features.c
+++ b/tests/x86_amd64_features.c
@@ -148,7 +148,8 @@ static Bool go(char* cpu)
     assert( !(cmask != 0 && dmask != 0 && bmask != 0) );
     assert( !(cmask == 0 && dmask == 0 && bmask == 0) );

-   if (require_amd && !vendorStringEquals("AuthenticAMD"))
+   if (require_amd && !vendorStringEquals("AuthenticAMD") &&
+       !vendorStringEquals("GenuineIntel"))
        return FEATURE_NOT_PRESENT;
        // regardless of what that feature actually is