Re: [Valgrind-developers] trying to use valgrind with openafs...

[Julian S. <js...@ac...>]

On Saturday 12 April 2003 2:47 pm, Nathan Neulinger wrote:
> Looking to try valgrinding the openafs user space tools and file server
> code. At a minimum, I needed to add
>
>       case __NR_afs_syscall: /* syscall 137 */
>          MAYBE_PRINTF("afs ( )\n");
>          KERNEL_DO_SYSCALL(tid,res);
>          break;
>
>
> What I'm wondering is - how much analysis code do y'all want in there...
> I can flesh out alot of the behavior of that system call, but are you
> interested in having it in there?

Well, there's a distinction to be made between _want_ and _need_.
At the bare minimum, you _must_ say how the state of memory is
altered after the syscall, otherwise memory checking won't work
correctly.  You need to tell V about changes in memory permissions
after the call.  

Optionally -- and this is done with almost all syscalls -- you can
add some stuff which checks addressibility & definedness of memory
passed to the system call.  This is nice to have -- it enables 
V to tell people to see when they are passing garbage to syscalls 
-- but it isn't per se essential.

I'd rather have as much detail as possible, since that makes it 
most useful to people debugging code with afs syscalls in, including
you :)

J