|
From: Nicholas N. <nj...@ca...> - 2003-03-18 12:29:37
|
On Tue, 18 Mar 2003, Eyal Lebedinsky wrote: > > We should probably #define the built types "int", etc, to some rubbish so > > that any use of them is detected... > > I am not clear on why we want to #define the 'int' types (you mean > inside struct vg_tm, right?). Sorry, I wasn't clear. We want to avoid using "int", "char", "unsigned int", etc, anywhere in the core or in skins, and instead use "Int", "Char", "UInt", etc. (This isn't really critical, I think, more for consistency.) One way to ensure this would be to put something like this in include/vg_skin.h: #define int no_such_type_as_int_use_Int_instead #define char no_such_type_as_char_use_Char_instead Then any accidental use of "int", "char", etc. would cause a compile error. > The added functions do use new types. Mostly, yes; but VG_(clo_time_zone) is a "long". I think it could/should be a "UInt" (32 bits is enough, right?) N |