|
From: Eyal L. <ey...@ey...> - 2003-03-18 12:23:20
|
Nicholas Nethercote wrote: > > On Tue, 18 Mar 2003, Eyal Lebedinsky wrote: > > > I hope it complies with the current programming model and style (please > > let me know where it fails to do so). > > >From a quick glance, style looks ok. One thing: you use the "long" type > for VG_(clo_time_zone)... use the Valgrind synonyms (eg. Long, although I > think UInt would be ok here?) > > We should probably #define the built types "int", etc, to some rubbish so > that any use of them is detected... I am not clear on why we want to #define the 'int' types (you mean inside struct vg_tm, right?). The added functions do use new types. Maybe, if it looks close enough, you can adjust it and check it in, and I will then read it and figure what it is that you wanted. -- Eyal Lebedinsky (ey...@ey...) <http://samba.org/eyal/> |