|
From: Nicholas N. <nj...@ca...> - 2002-10-21 09:02:15
|
On 18 Oct 2002, Jeremy Fitzhardinge wrote: > 14-hg-tid > HELGRIND: This fixes a bug in Helgrind in which all memory access by > syscalls was being treated as if it were happening in thread 1. This is > because the eraser_mem_read/write functions were using > get_current_tid_1_if_root() to get the current tid. Unfortunately, > during syscalls there is no current thread, so it was getting 1_if_root. > This patch fixes this by using what thread ID information we're given, > and only using get_current_tid() if we're recording a memory access > performed by code (rather than by a syscall). Well done for spotting this. I suspected/hoped that there would be a single bug that accounted for a lot of the garbage output. Accept my apologies for my wretched coding in the first place :) N |