|
From: Jeremy F. <je...@go...> - 2002-10-11 05:48:59
|
On Thu, 2002-10-10 at 12:25, Jeremy Fitzhardinge wrote: > This means that if a particular program under study has callbacks for > different skins, they will end up doing the wrong thing if run with the > wrong skin. It seems to me that there needs to be a systematic way for > skins to distinguish their callback numbers from each other. Maybe > encode some kind of skin ID into the top 16 bits of the request number? Well, since there seems to be a de-facto standard for each skin to have a two letter code, I implemented a scheme to use it as a way for skins to distinguish their client requests. I also made it not an error for a callback to be unimplemented, since Valgrind is getting more capable with more skins, it will be common to have a program with client requests inserted for multiple skins. As part of this, I changed the interface to SK_(handle_client_request) so that a skin can indicate that it did not handle the request, so that the proper default return value can be returned. Patch against CVS head. J |