Re: [Valgrind-developers] [valgrind] Wrap linux specific syscalls 457 (listmount) and 458 (statmount)

[Mark W. <ma...@kl...>]

Hi Matthias,

On Sat, Jun 28, 2025 at 04:22:21PM +0200, Matthias Schwarzott wrote:
> I have one observation to that change. see below.
> [...]
> diff --git a/coregrind/m_syswrap/syswrap-mips32-linux.c
> b/coregrind/m_syswrap/syswrap-mips32-linux.c
> >index 5edae82c31..734f129c87 100644
> >--- a/coregrind/m_syswrap/syswrap-mips32-linux.c
> >+++ b/coregrind/m_syswrap/syswrap-mips32-linux.c
> >@@ -1182,6 +1182,8 @@ static SyscallTableEntry syscall_main_table[] = {
> >     LINXY(__NR_cachestat,               sys_cachestat),               // 451
> >     LINX_(__NR_fchmodat2,               sys_fchmodat2),               // 452
> >+   LINX_(__NR_statmount,               sys_statmount),               // 457
> >+   LINX_(__NR_listmount,               sys_listmount),               // 458
> >     LINX_(__NR_mseal,                   sys_mseal),                   // 462
> >  };
> This hunk adds LINX_-entries for mips32.
> In contrast all other archs use the macro LINXY.

Oops. Sharp eyes. And we don't have any mips32 nightly testers or
builders. So nobody else noticed.

Fixed in commit 6adb4391cb20 "mips32: Use LINXY for statmount and listmount"

Thanks,

Mark