Re: [Valgrind-developers] ir_opt.c tweaks

[Florian K. <fl...@ei...>]

Hi Mark,

thanks for the review. Checked in as 4b8dcbb146.

On 19.06.25 23:54, Mark Wielaard wrote:
> 
> Do you happen to have a list or is there a bug for "missing constant
> folding oppertunities" that someone could try?
> 

There is no bug that I could find and I don't have a list either. But it would 
be worthwhile to fill in the gaps. Constant folding is a cheap and easy thing to 
do and effective. Algebraic identities are a different story as they need to 
recurse the subtrees (sameIRexprs).

Anyhow, I'll bite and make a pass and see what is missing for operations of 
integer type except Ity_I128. I got quite puzzled to see that an U128 constant 
is represented by an UShort rather than a __uint128_t.

     Florian