[Valgrind-developers] [valgrind] Hide "client tried to modify addresses" warnings when -q (quiet) is set

[Mark W. <ma...@so...>]

https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=47f2f1df4112e9befe2d0039d7e4f6c957669b6e

commit 47f2f1df4112e9befe2d0039d7e4f6c957669b6e
Author: Martin Cermak <mc...@re...>
Date:   Wed May 28 18:04:46 2025 +0200

    Hide "client tried to modify addresses" warnings when -q (quiet) is set
    
    When -q is set, that is when verbosity is 0, the "client tried to
    modify addresses" warning should be hidden.
    
    Also remove the warning from {freebsd,solaris}/scalar.stderr.exp
    
    Reproducer: TESTS=munmap03 make -j$(nproc) ltpchecks
    
    https://bugs.kde.org/show_bug.cgi?id=504919

Diff:
---
 NEWS                                         | 1 +
 coregrind/m_syswrap/syswrap-generic.c        | 8 +++++---
 memcheck/tests/freebsd/scalar.stderr.exp     | 1 -
 memcheck/tests/freebsd/scalar.stderr.exp-x86 | 1 -
 memcheck/tests/solaris/scalar.stderr.exp     | 1 -
 5 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/NEWS b/NEWS
index dab995c632..041d7afdf3 100644
--- a/NEWS
+++ b/NEWS
@@ -38,6 +38,7 @@ are not entered into bugzilla tend to get forgotten about or ignored.
 504466  Double close causes SEGV
 504904  Hide "bad act handler address" warnings when -q (quiet) flag is set
 504909  Hide "Bad oldset address" warnings when -q (quiet) flag is set
+504919  Hide "client tried to modify addresses" warnings when -q (quiet) set
 504936  Add FreeBSD amd64 sysarch subcommands AMD64_SET_TLSBASE and
         AMD64_GET_TLSBASE
 
diff --git a/coregrind/m_syswrap/syswrap-generic.c b/coregrind/m_syswrap/syswrap-generic.c
index 98cbb172fd..f8d73e1973 100644
--- a/coregrind/m_syswrap/syswrap-generic.c
+++ b/coregrind/m_syswrap/syswrap-generic.c
@@ -121,9 +121,11 @@ Bool ML_(valid_client_addr)(Addr start, SizeT size, ThreadId tid,
 		  syscallname, start, start+size-1, (Int)ret);
 
    if (!ret && syscallname != NULL) {
-      VG_(message)(Vg_UserMsg, "Warning: client syscall %s tried "
-                               "to modify addresses %#lx-%#lx\n",
-                               syscallname, start, start+size-1);
+      if (VG_(clo_verbosity) >= 1) {
+         VG_(message)(Vg_UserMsg, "Warning: client syscall %s tried "
+                                  "to modify addresses %#lx-%#lx\n",
+                                  syscallname, start, start+size-1);
+      }
       if (VG_(clo_verbosity) > 1) {
          VG_(get_and_pp_StackTrace)(tid, VG_(clo_backtrace_size));
       }
diff --git a/memcheck/tests/freebsd/scalar.stderr.exp b/memcheck/tests/freebsd/scalar.stderr.exp
index 59ed185242..24b7ba2bbd 100644
--- a/memcheck/tests/freebsd/scalar.stderr.exp
+++ b/memcheck/tests/freebsd/scalar.stderr.exp
@@ -610,7 +610,6 @@ Syscall param mprotect(len) contains uninitialised byte(s)
 Syscall param mprotect(prot) contains uninitialised byte(s)
    ...
 
-Warning: client syscall mprotect tried to modify addresses 0x........-0x........
 ---------------------------------------------------------
  75:             SYS_madvise 3s 0m
 ---------------------------------------------------------
diff --git a/memcheck/tests/freebsd/scalar.stderr.exp-x86 b/memcheck/tests/freebsd/scalar.stderr.exp-x86
index 091a1770d6..788dfbd7c0 100644
--- a/memcheck/tests/freebsd/scalar.stderr.exp-x86
+++ b/memcheck/tests/freebsd/scalar.stderr.exp-x86
@@ -610,7 +610,6 @@ Syscall param mprotect(len) contains uninitialised byte(s)
 Syscall param mprotect(prot) contains uninitialised byte(s)
    ...
 
-Warning: client syscall mprotect tried to modify addresses 0x........-0x........
 ---------------------------------------------------------
  75:             SYS_madvise 3s 0m
 ---------------------------------------------------------
diff --git a/memcheck/tests/solaris/scalar.stderr.exp b/memcheck/tests/solaris/scalar.stderr.exp
index d80bc27d07..e7951dae77 100644
--- a/memcheck/tests/solaris/scalar.stderr.exp
+++ b/memcheck/tests/solaris/scalar.stderr.exp
@@ -618,7 +618,6 @@ Syscall param shmsys_shmdt(opcode) contains uninitialised byte(s)
 Syscall param shmsys_shmdt(shmaddr) contains uninitialised byte(s)
    ...
 
-Warning: client syscall shmdt tried to modify addresses 0x........-0x........
 ---------------------------------------------------------
  52:              SYS_shmsys (SHMGET) 4s 0m
 ---------------------------------------------------------