Re: [Valgrind-developers] Created VALGRIND_3_25_BRANCH

[Mark W. <ma...@kl...>]

Hi Paul,

On Mon, May 19, 2025 at 08:38:04AM +0200, Paul Floyd via Valgrind-developers wrote:
> 
> On 5/16/25 11:41, Mark Wielaard wrote:
> >How many commit are there for freebsd to cherry-pick?
> >If you give me a list I can do them for you.
> >
> There are 2 for sure and 2 if you'd like to add the new vgstack
> script to 3.25.1.
> 
> Definitely:
> 
> commit 4f3f688a31ef1a213bd1a3a9e897e99cfe3950f6
> Author: Paul Floyd <pj...@wa...>
> Date:   Fri May 16 07:58:02 2025 +0200
> 
>    Bug 504265 - FreeBSD: missing syscall wrappers for fchroot and setcred
> 
> commit 8dbf86733e76d30c194f5321a72c6b44f1055e20
> Author: Paul Floyd <pj...@wa...>
> Date:   Fri May 16 21:32:02 2025 +0200
> 
>    FreeBSD regtest: updates for FreeBSD 15.0-CURRENT

I cherry-picked these two. But dropped the .gitignore update, because
that file isn't in a release tar and so the patch wouldn't apply when
someone would try to apply it directly on top of the previous release.

> Maybe:
> 
> commit 568ce38ac76e1cefc20b006c7da8cf7bf2209596
> Author: Paul Floyd <pj...@wa...>
> Date:   Tue May 13 20:34:48 2025 +0200
> 
>    Bug 504101 - Add a "vgstack" script
> 
> commit 382efd0ccbe8447eca4bde0068a205a01d02f90e
> Author: Paul Floyd <pj...@wa...>
> Date:   Mon May 19 08:23:57 2025 +0200
> 
>    Script: move vgstack to configure.ac section with chmod -x

But not these two. Although it is just a small new feature (and pretty
cool!) it would make 3.25.1 not be a simple drop-in for 3.25.0 because
packagers will have to adjust things so that the new script gets
installed and possibly be placed in a particular subpackage.

The VALGRIND_3_25_BRANCH now contains these commits:

 Add fixed bug 504466 double close causes SEGV to NEWS
 FreeBSD regtest: updates for FreeBSD 15.0-CURRENT
 FreeBSD: missing syscall wrappers for fchroot and setcred
 Check whether file descriptor is inherited before printing where_opened
 More gdb filtering for glibc 2.41 with debuginfo installed
 Linux PPC64 syscall: add sys_io_pgetevents
 riscv64: Fix nan-boxing for single-precision calculations
 regtest: use /bin/cat in none/tests/fdleak_cat.vgtest
 Don't count closed inherited file descriptors
 Add workaround for missing riscv_hwprobe syscall (258)
 mount syscall param filesystemtype may be NULL
 Bug 503641 - close_range syscalls started failing with 3.25.0
 FreeBSD close_range syscall

Which fix these bugs:

 503098  Incorrect NAN-boxing for float registers in RISC-V
 503641  close_range syscalls started failing with 3.25.0
 503914  mount syscall param filesystemtype may be NULL
 504177  FILE DESCRIPTORS banner shows when closing some inherited fds
 504265  FreeBSD: missing syscall wrappers for fchroot and setcred
 504466  Double close causes SEGV

I'll create an official 3.25.1 release tomorrow from the branch (after
updating the version number of course).

Cheers,

Mark