Re: [Valgrind-developers] Created VALGRIND_3_25_BRANCH (should we do a 3.25.1 release?)

[Mark W. <ma...@kl...>]

Hi,

On Sat, May 10, 2025 at 02:13:25AM +0200, Mark Wielaard wrote:
> Hi developers and packagers,
> 
> I created a VALGRIND_3_25_BRANCH where I hope to put commits
> which I think distros should pick up. The idea would be to first
> commit to the main branch. Then git cherry-pick -x the commit to the
> branch (updating NEWS to list all bugs fixed on the branch).
> 
> The patches I put on the VALGRIND_3_25_BRANCH are to fix the
> close_range syscall, a fixlet for the mount syscall type param and a
> workaround for missing riscv_hwprobe syscall support.

I put two more commits on the branch:

  - Don't count closed inherited file descriptors
  - regtest: use /bin/cat in none/tests/fdleak_cat.vgtest

This resolves a regression seen in the elfutils testsuite which runs
with -q --track-fds=yes.

> I saw multiple reports about users having issues with the close_range
> syscall being broken. So it might be good to do a 3.25.1 release from
> the branch. I hope distros will pick up these fixes, I have already
> added them to the Fedora package. But having an explicit release might
> trigger more distros to update. Lets discuss next week if others feel
> it is urgent enough.

Any opinions on this? Everything is ready to do a 3.25.1 release from
the branch, but it is a little extra work. Does anybody feel this is a
good idea? Or should we just ask distros to take the fixes from the
branch?

> Please let me know if you find other fixes on trunk you believe really
> should be backported to the 3.25 branch/3.25.1 release.
> 
> Thanks,
> 
> Mark
> 
>   Set version to 3.25.1.GIT
>   Prepare NEWS for branch 3.25 fixes
>   FreeBSD close_range syscall
>   Bug 503641 - close_range syscalls started failing with 3.25.0
>   mount syscall param filesystemtype may be NULL
>   Add workaround for missing riscv_hwprobe syscall (258)