Re: [Valgrind-developers] missing -Wformat warnings

[Florian K. <fl...@ei...>]

Hi Paul,

thanks for the review.

On 12.05.25 21:49, Paul Floyd via Valgrind-developers wrote:
> 
> One little nit, there's a missing second underscore in the first #ifdef in this 
> part of the diff
> 
> +#ifdef __GNUC_

yep..

> LLVM clang also defines __GNUC__ so to make things GCC only you also need "&& 
> !defined(__clang__)"
> 

I didn't know that. Thx for pointing that out. I'll fix both issues.

> I think that it would be cleaner just to fix the printf:
> 
> printf("%s", "");

Oh, absolutely. I tried that but then the sem_open_traced testcase failed. The 
code in question is a hack to work around a presumed to be GCC 9.2.1 miscompile. 
I'm using GCC 11.4 by default. So not sure whether the problem there is actually 
a miscompile or something else. But that is for Bart to figure out :)

I presume the patch is OK with those fixes?

Cheers,
    Florian