Re: [Valgrind-developers] XML summaries - context counts

[Mark W. <ma...@kl...>]

Hi Paul,

On Sun, May 11, 2025 at 01:18:18PM +0200, Paul Floyd via Valgrind-developers wrote:
> I'm about ready to push the changes for
> https://bugs.kde.org/show_bug.cgi?id=390310
> 
> One thing I'd like some other opinion(s) on is the tag used for the
> summaries.
> 
> At the moment the non-xml output looks like
> 
> ==3166== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 3 from 3)
> 
> With this patch the corresponding xml summary is
> 
> 
> <error_summary>
>  <errors>1</errors>
>  <from>1</from>
>  <suppressed>3</suppressed>
>  <suppressed_from>3</suppressed_from>
> </error_summary>
> 
> Do you think that would be clearer using "contexts" rather than "from"?
> 
> 
> <error_summary>
>  <errors>1</errors>
>  <error_contexts>1</error_contexts>
>  <suppressed>3</suppressed>
>  <suppressed_contexts>3</suppressed_contexts>
> </error_summary>

Yes, I think using "contexts" is clearer than using "from".

We should probably also update:

./docs/internals/xml-output.txt
./docs/internals/xml-output-protocol4.txt
./docs/internals/xml-output-protocol5.txt

4 is the default output, 5 is with --track-fds enabled (so it includes
core error elements). Maybe after this change goes in we should update
the (default) protocol version to 6?

Cheers,

Mark