[Valgrind-developers] Makefile.am change (needs review)

[Florian K. <fl...@ei...>]

In none/tests/s390x/disasm-test there is the executable disasm-test which needs 
VEX/libvex-s390x-linux.a.
Building works fine. However, if I change a C file in VEX/priv and rebuild then 
only libvex-s390x-linux.a is being rebuilt - but not the executable.
I'm not an autotools wiz. With some guessing I found that this change

diff --git a/none/tests/s390x/disasm-test/Makefile.am 
b/none/tests/s390x/disasm-test/Makefile.am
index 775848921..ce662cb86 100644
--- a/none/tests/s390x/disasm-test/Makefile.am
+++ b/none/tests/s390x/disasm-test/Makefile.am
@@ -30,6 +30,6 @@ disasm_test_CPPFLAGS     = $(AM_CPPFLAGS_PRI) \
                             -I$(top_srcdir)/VEX/pub \
                             -I$(top_srcdir)/VEX/priv
  disasm_test_CFLAGS       = $(AM_CFLAGS_PRI)
-disasm_test_DEPENDENCIES =
+disasm_test_DEPENDENCIES = 
$(top_builddir)/VEX/libvex-@VGCONF_ARCH_PRI@-@VGCONF_OS@.a
  disasm_test_LDADD        = 
$(top_builddir)/VEX/libvex-@VGCONF_ARCH_PRI@-@VGCONF_OS@.a
  disasm_test_LDFLAGS      = $(AM_CFLAGS_PRI) @LIB_UBSAN@

does the trick. Is this the proper way?

BTW: memcheck/tests/vbit-test has the same issue

Thanks,
    Florian