Re: [Valgrind-developers] Request to contribute on SSE4a support

[Pol M. S. <pol...@gm...>]

Hello,

I'd need some assistance on how to submit a patch to the sourceware repo,
at the moment I have a patch cleaned up with all instructions implemented.
I am unfamiliar with the process (I am used to the PR mechanisms of
bitbucket/gitlab/github)

Sorry for writing a similar message to both the mailing list and the IRC

Best regards,

Pol Marcet Sardà

Missatge de Pol Marcet Sardà <pol...@gm...> del dia ds., 25 de
gen. 2025 a les 18:14:

> Hi,
>
> in an application I develop, compilers tend to emit from time to time
> SSE4a instructions as I target AMD CPUs. I filed a bug (486398) a while
> ago, but given that I faced this same issue recently, I guessed that there
> simply hadn't been bandwidth for a more than a decade old niche set of
> instructions.
>
> Given that I still need them, and that there are only 4 instructions, I
> have already added support for the INSERTQ and EXTRQ into VEX, and I intend
> to finish the job by implementing MOVNTSD & MOVNTSS.
>
> Looking at the documentation, it seems to assume that you need to have
> write access into the repo to publish code, so I'd like to request some
> assistance regarding the logistics of submitting a patch (or, if possible,
> creating a pull request).
>
> The documentation also mentions that I should use clang-format, but after
> applying the formatting all the code changed, making a diff completely
> unreadable. May I know if this is expected? Maybe VEX has been touched on
> less, and hasn't had its formatting updated yet? Did I configure something
> wrong?
>
> I'm certain that I'll have gotten some subtleties of Valgrind wrong, so
> once I do submit a patch, please, review it thoroughly! :D
>
> Regards,
>
> Pol Marcet Sardà
>
>