[Valgrind-developers] [valgrind] Let gdbserver the support of 'x' packet by adding binary-upload+ in qSupported.

[Philippe W. <phi...@so...>]

https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=388e6732852c3be128af601901447980dfc526b7

commit 388e6732852c3be128af601901447980dfc526b7
Author: Philippe Waroquiers <phi...@sk...>
Date:   Tue Jan 28 15:33:15 2025 +0100

    Let gdbserver the support of 'x' packet by adding binary-upload+ in qSupported.
    
    Following the incompatible implementation of the 'x' packet between
    lldb and gdb, gdb now only uses the x packet if the gdbserver
    reports binary-upload+ in qSupported.
    
    Tested with gdb 16.1, gdb 16 branch and gdb 17 trunk, each time checking
    the 'x' packet was effectively used.

Diff:
---
 coregrind/m_gdbserver/server.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/coregrind/m_gdbserver/server.c b/coregrind/m_gdbserver/server.c
index 939b7f2931..410ebf3bc3 100644
--- a/coregrind/m_gdbserver/server.c
+++ b/coregrind/m_gdbserver/server.c
@@ -1126,6 +1126,8 @@ void handle_query (char *arg_own_buf, int *new_packet_len_p)
       /* Note: max packet size including frame and checksum, but without
          trailing null byte, which is not sent/received. */
 
+      strcat (arg_own_buf, ";binary-upload+");
+
       strcat (arg_own_buf, ";QStartNoAckMode+");
       strcat (arg_own_buf, ";QPassSignals+");
       strcat (arg_own_buf, ";QCatchSyscalls+");