Re: [Valgrind-developers] zstd.h missing in make dist tarball

[Paul F. <pj...@wa...>]

On 22-12-24 22:25, Florian Krohm wrote:

> Yes, that could be done, even though it is kinda moot now that zstd.h
> is being shipped.
> 
> Another possibility would be to enhance check_makefile_consistency to
> catch headers that are included but not shipped. That script runs as 
> part of post_regtest_checks already. But changing it is more complex 
> than integrating make distcheck there.

Is it really too late to change? zstd was added after the release of 
3.24 and it isn't an exported header.

Adding a script to do the checking seems a good idea to me. make 
distcheck is quite time consuming - it makes the docs, tarball, extracts 
the tarball to _build and does a full build. A script could do something 
like

foreach directory
    get list of dist headers from Makefile.am
    get list of used headers from Po files
    check lists match

A+
Paul