Re: [Valgrind-developers] zstd.h missing in make dist tarball

[Florian K. <fl...@ei...>]

Hi Mark,

On 22.12.24 21:28, Mark Wielaard wrote:
> 
> There is at least one buildbot that includes make distcheck.
> https://builder.sourceware.org/buildbot/#/builders/valgrind-fedora-x86_64
> (But that did have zstd-devel installed so...)
> 

That's good.

>>> But if you have zstd devel headers
>>> installed the build will pick up the /usr/include/zstd.h variant.
>>
>> Interesting. So, ideally, make distcheck ought to run on a machine
>> where these headers are not installed.
> 
> Or maybe we should rename the internal copy to vg-zstd.h ?

Yes, that could be done, even though it is kinda moot now that zstd.h
is being shipped.

Another possibility would be to enhance check_makefile_consistency to
catch headers that are included but not shipped. That script runs as part of 
post_regtest_checks already. But changing it is more complex than integrating 
make distcheck there.

Cheers,
   Florian