Re: [Valgrind-developers] zstd.h missing in make dist tarball

[Mark W. <ma...@kl...>]

Hi Florian,

On Sun, Dec 22, 2024 at 11:06:04AM +0100, Florian Krohm wrote:
> On 21.12.24 23:01, Mark Wielaard wrote:
> >
> >No objection. It looks correct.  I was just wondering why make
> >distcheck didn't detect it.
> 
> The reason could be that make distcheck is run on demand only. ?
> I think it would be good to run make distcheck as part of
> post_regtest_checks.
> That way we'd catch the problem early on in the nightly runs.
> Doing so implies, though, that you have xml machinery installed
> which is not universally so.

There is at least one buildbot that includes make distcheck.
https://builder.sourceware.org/buildbot/#/builders/valgrind-fedora-x86_64
(But that did have zstd-devel installed so...)

> >But if you have zstd devel headers
> >installed the build will pick up the /usr/include/zstd.h variant.
> 
> Interesting. So, ideally, make distcheck ought to run on a machine
> where these headers are not installed.

Or maybe we should rename the internal copy to vg-zstd.h ?

Cheers,

Mark