Re: [Valgrind-developers] [valgrind] regtest: turn off exec stack warning

[Philippe W. <phi...@sk...>]

The below change causes a build failure on the gcc110 compile farm

valgrind revision: valgrind-3.25.0.GIT-544d41e525-20241221
C compiler:        gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-44)
GDB:               GNU gdb (GDB) Red Hat Enterprise Linux 7.6.1-120.el7
Assembler:         GNU assembler version 2.27-44.base.el7_9.1
C library:         GNU C Library (GNU libc) stable release version 2.17
uname -mrs:        Linux 3.10.0-1160.105.1.el7.ppc64 ppc64
Vendor version:    CentOS Linux 7 (AltArch)

Nightly build on gcc110 ( \S, ppc64 )
Started at 2024-12-22 03:00:02 UTC
Ended   at 2024-12-22 03:25:19 UTC
Results differ from 24 hours ago

   Checking out Valgrind source tree  ... done
   Configuring valgrind               ... done
   Building valgrind                  ... failed

Last 20 lines of verbose log follow echo
gcc -std=gnu99 -Winline -Wall -Wshadow -Wno-long-long -g -fno-stack-protector   -m64    -o
use_after_close use_after_close.o 
gcc -std=gnu99 -Winline -Wall -Wshadow -Wno-long-long -g -fno-stack-protector   -m64  -
Wl,--no-warn-execstack  -o nestedfns nestedfns-nestedfns.o 
gcc -std=gnu99 -Winline -Wall -Wshadow -Wno-long-long -g -fno-stack-protector   -m64    -o
rlimit64_nofile rlimit64_nofile.o 
gcc -std=gnu99 -Winline -Wall -Wshadow -Wno-long-long -g -fno-stack-protector   -m64    -o
ppoll_alarm ppoll_alarm.o -lpthread
/usr/bin/ld: unrecognized option '--no-warn-execstack'
/usr/bin/ld: use the --help option for usage information
collect2: error: ld returned 1 exit status
make[5]: *** [nestedfns] Error 1
make[5]: *** Waiting for unfinished jobs....
gcc -std=gnu99 -Winline -Wall -Wshadow -Wno-long-long -g -fno-stack-protector   -m64 -ansi
-o ansi ansi-ansi.o 
make[5]: Leaving directory `/home/philippe/valgrind/cron_nightly/nightly/valgrind-
new/none/tests'
make[4]: *** [check-am] Error 2
make[4]: Leaving directory `/home/philippe/valgrind/cron_nightly/nightly/valgrind-
new/none/tests'
make[3]: *** [check-recursive] Error 1
make[3]: Leaving directory `/home/philippe/valgrind/cron_nightly/nightly/valgrind-
new/none/tests'
make[2]: *** [check-recursive] Error 1
make[2]: Leaving directory `/home/philippe/valgrind/cron_nightly/nightly/valgrind-
new/none'
make[1]: *** [check-recursive] Error 1valgrind revision: valgrind-3.25.0.GIT-544d41e525-
20241221


On Sat, 2024-12-21 at 16:21 +0000, Paul Floyd wrote:
> https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=0446f4ec3d11f8be373ef36edbec9818e1e1f4d4
> 
> commit 0446f4ec3d11f8be373ef36edbec9818e1e1f4d4
> Author: Paul Floyd <pj...@wa...>
> Date:   Sat Dec 21 17:18:35 2024 +0100
> 
>     regtest: turn off exec stack warning
>     
>     Rather than turning off exec stack.
> 
> Diff:
> ---
>  none/tests/Makefile.am | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/none/tests/Makefile.am b/none/tests/Makefile.am
> index fa0128d3a8..76825b9478 100644
> --- a/none/tests/Makefile.am
> +++ b/none/tests/Makefile.am
> @@ -335,7 +335,7 @@ endif
>  
>  if HAVE_NESTED_FUNCTIONS
>     check_PROGRAMS += nestedfns
> -   nestedfns_LDFLAGS = -Wl,-z,noexecstack
> +   nestedfns_LDFLAGS = -Wl,--no-warn-execstack
>  endif
>  
>  # This doesn't appear to be compilable on Darwin.
> 
> 
> _______________________________________________
> Valgrind-developers mailing list
> Val...@li...
> https://lists.sourceforge.net/lists/listinfo/valgrind-developers