Re: [Valgrind-developers] zstd.h missing in make dist tarball

[Florian K. <fl...@ei...>]

On 21.12.24 23:01, Mark Wielaard wrote:
> 
> No objection. It looks correct.  I was just wondering why make
> distcheck didn't detect it.  

The reason could be that make distcheck is run on demand only. ?
I think it would be good to run make distcheck as part of
post_regtest_checks. That way we'd catch the problem early on in the nightly runs.
Doing so implies, though, that you have xml machinery installed which is not 
universally so.

> But if you have zstd devel headers
> installed the build will pick up the /usr/include/zstd.h variant.
> 

Interesting. So, ideally, make distcheck ought to run on a machine where these 
headers are not installed.

   Florian