Re: [Valgrind-developers] zstd.h missing in make dist tarball

[Mark W. <ma...@kl...>]

Hi Paul,

On Sat, Dec 21, 2024 at 10:02:12PM +0100, Paul Floyd via Valgrind-developers wrote:
> 
> On 20-12-24 19:19, Florian Krohm wrote:
> >diff --git a/coregrind/Makefile.am b/coregrind/Makefile.am
> >index 4eeb6e3d2..63bbc5ef5 100644
> >--- a/coregrind/Makefile.am
> >+++ b/coregrind/Makefile.am
> >@@ -265,6 +265,7 @@ noinst_HEADERS = \
> >         m_debuginfo/lzoconf.h           \
> >         m_debuginfo/lzodefs.h           \
> >         m_debuginfo/minilzo.h           \
> >+       m_debuginfo/zstd.h              \
> >         m_demangle/ansidecl.h   \
> >         m_demangle/cp-demangle.h \
> >         m_demangle/dyn-string.h \
> 
> I can reproduce this. Unless there are any objections I'll push this
> change tomorrow.

No objection. It looks correct.  I was just wondering why make
distcheck didn't detect it.  But if you have zstd devel headers
installed the build will pick up the /usr/include/zstd.h variant.

Cheers,

Mark