Re: [Valgrind-developers] [PATCH v3] Fixes PLAT_amd64_win64 support

[罗勇刚(Yonggang L. <luo...@gm...>]

On Fri, Dec 13, 2024 at 4:55 AM Bart Van Assche <bar...@gm...>
wrote:
>
> On 12/12/24 3:18 AM, 罗勇刚(Yonggang Luo) wrote:
> > uintptr is fine, but I am not sure every compiler have ` uintptr_t`,
> > that depends on header file
>
> We can ask Windows users to include <stdint.h> before
> <valgrind/valgrind.h>. We can't ask this from Unix users because this
> could break existing code bases. In other words, I'm in favor of using
> uintptr_t for Win64 instead of unsigned long long.
>
Update the patch to not affect Unix users, handling cases for
PLAT_amd64_win64
in separate code so that it's won't affect Unix users in Patch V5

> Thanks,
>
> Bart.



--
         此致
礼
罗勇刚
Yours
    sincerely,
Yonggang Luo