Re: [Valgrind-developers] [PATCH v4] Fixes PLAT_amd64_win64 support

[Bart V. A. <bar...@gm...>]

On 12/11/24 3:02 AM, Yonggang Luo wrote:
> sizeof(unsigned long int) is 4 on mingw 64bit, use unsigned long long int instead
> 
> __clang__ for MSVC support for inline assembly
> 
> _MSC_VER win64 do not support inline assembly, use stub instead

Please follow the "one change per patch" rule. There are multiple
unrelated changes in this patch. A few examples:
- Changing "unsigned long int" into "unsigned long long int" should be a
   patch by itself.
- Adding support for MSVC (_MSC_VER) should be a patch by itself too.

Bart.