Re: [Valgrind-developers] [PATCH v3] Fixes PLAT_amd64_win64 support

[Mark W. <ma...@kl...>]

On Thu, Dec 12, 2024 at 03:36:26PM +0800, 罗勇刚(Yonggang Luo) wrote:
> Any reviews? I think this can be get merged

There were a couple of questions which I am not sure I saw an answer
to. Could you explain how you tested?  Why aren't you creating a new
section for win64?  You are adding it as a variant of 64bit
linux/freebsd, but then need to change the data type of some, why is
that OK for the existing platforms?  The patch Bart added for win32
used uintptr, which seems a better data type than long long.

Thanks,

Mark