Re: [Valgrind-developers] [PATCH] sizeof(unsigned long int) is 4 on mingw 64bit, use unsigned long long int instead

[Mark W. <ma...@kl...>]

Hi Yonggang,

On Sun, 2024-12-08 at 05:44 +0800, Yonggang Luo wrote:
> @@ -468,7 +468,10 @@ typedef
>                      );                                           \
>   } while (0)
>  
> -#endif /* PLAT_amd64_linux || PLAT_amd64_darwin || PLAT_amd64_solaris */
> +#endif /* defined(PLAT_amd64_linux)  ||  defined(PLAT_amd64_darwin) \
> +    ||  defined(PLAT_amd64_solaris) \
> +    ||  defined(PLAT_amd64_freebsd) \
> +    ||  (defined(PLAT_amd64_win64) && defined(__GNUC__)) */
>  
>  /* ------------------------- amd64-Win64 ------------------------- */

Should this be its own thing?

We do have some minimal PLAT_amd64_win32 support see
https://bugs.kde.org/show_bug.cgi?id=210935
but that is its own thing and only works for compiling client requests
that are triggered under Wine.

The original support for mingw64 seemed to use uintptr instead.
See commit 045b8ab23eca0881b9847aa09c74bbacd19a55d7

Thanks,

Mark