Re: [Valgrind-developers] [valgrind] Solaris and Illumos: fix build due to use of memset in zstd code.

[Paul F. <pj...@wa...>]

On 24-11-24 18:28, Paul Floyd via Valgrind-developers wrote:

> We could have the subset of non __ prefixed ones always defined for all 
> platforms.

I hadn't thought through the question of declarations.

In the case of compilers optimizing a struct assignment to memcpy 
there's no need for the compiler to see the prototype since it is implicit.

In the case of third party code we do need to see a prototype. Also 
whilst almost all libc functions have drop-in VG_() replacements 
'malloc' doesn't because VG_(malloc) takes an extra string tag for the 
first argument.

I need to think about this a bit more.

A+
Paul