[Valgrind-developers] [valgrind] Illumos: Don't call ML_(fd_allowed) from PRE(sys_fstat)

[Paul F. <pa...@so...>]

https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=ab632865cfeabf8457f0f899016ff5a74ed02216

commit ab632865cfeabf8457f0f899016ff5a74ed02216
Author: Paul Floyd <pj...@wa...>
Date:   Sat Nov 9 18:17:26 2024 +0100

    Illumos: Don't call ML_(fd_allowed) from PRE(sys_fstat)
    
    This was causing many false positives with --track-fds=yes

Diff:
---
 coregrind/m_syswrap/syswrap-solaris.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/coregrind/m_syswrap/syswrap-solaris.c b/coregrind/m_syswrap/syswrap-solaris.c
index f43c2f30a9..9d869d9b5f 100644
--- a/coregrind/m_syswrap/syswrap-solaris.c
+++ b/coregrind/m_syswrap/syswrap-solaris.c
@@ -2357,10 +2357,6 @@ PRE(sys_fstat)
    PRINT("sys_fstat ( %ld, %#lx )", SARG1, ARG2);
    PRE_REG_READ2(long, "fstat", int, fildes, struct stat *, buf);
    PRE_MEM_WRITE("fstat(buf)", ARG2, sizeof(struct vki_stat));
-
-   /* Be strict. */
-   if (!ML_(fd_allowed)(ARG1, "fstat", tid, False))
-      SET_STATUS_Failure(VKI_EBADF);
 }
 
 POST(sys_fstat)