Re: [Valgrind-developers] extending vg_regtest to also produce automake-flavoured result files

[Frank C. E. <fc...@re...>]

Hi -

> > OK, trimmed off all line-ending whitespace throughout file.
> 
> Thanks. Although I am not a fan of doing it for the whole file at the
> same time as the rest of the patch (now it is slightly more difficult
> to see what the real change is without using git show -w -b).

Yeah, sorry about that, but then again stuff like this rarely gets done
otherwise. ;-)

> [...]
> I haven't looked at the bunsen import, I assume you have and that it
> looks fine?

Definitely (can see them on sourceware).

> One last request. Could you add a little paragraph under "Running the
> regression tests" in README_DEVELOPERS about the test-suite*.log and
> *.vgtest.[trs|log] files?

Done, it says:

+The details of each vgtest run are logged to individual "vgtest.log"
+files.  These are listed, and non-passing tests detailed, in the
+test-suite-overall.log file.  (Token *.trs and test-suite.log files
+are also created, for emulating automake-style testsuites, as expected
+by tools such as bunsen.)

Code in the users/fche/try-vgregtest branch updated.  Thanks for the review!

- FChE