Re: [Valgrind-developers] Updated VALGRIND_3_23_BRANCH

[Mark W. <ma...@kl...>]

On Mon, Jun 10, 2024 at 05:04:00PM +0200, Mark Wielaard wrote:
> Hi developers and packagers,
> 
> I updated the VALGRIND_3_23_BRANCH with some patches to unbreak mips,
> fix memccpy false positives, inotify_init syscall handling, add aarch64
> frinta and frinta vector instructions and clean up the s390x extension
> mechanism and some testcases.
> 
> I don't intent to do a full 3.23.1 release, but I hope distros will
> pick up these fixes. I have also added them to the Fedora package.

I added 4 more commits to the 3.23 branch to fix an odd x86_64 prefix
issue, remove internal valgrind file descriptor leaking that could
result in false positives with --track-fds=yes and deny programs to
call fcntl on valgrind internal fds.

commit e62c7b4f9ee0a8c20c7211a92ad512f925e9515c
Author: Paul Floyd <pj...@wa...>
Date:   Sun Jun 16 09:25:51 2024 +0200

    Bug 487439 - SIGILL in JDK11, JDK17
    
    (cherry picked from commit c19d19d34a6dadaf4a9d590f516f813e9cbacdd0)

commit 14cefe7c645a3148165f4b2fa6095d9446e378c7
Author: Mark Wielaard <ma...@kl...>
Date:   Sun Jun 16 21:23:08 2024 +0200

    Don't leave fds created with --log-file, --xml-file or --log-socket open
    
    prepare_sink_fd and prepare_sink_socket will create a new file
    descriptor for the output sink. finalize_sink_fd then copies the fd
    to the safe range, so it doesn't conflict with any application fds.
    
    If we created the original fd ourselves, it was a VgLogTo_File or
    VgLogTo_Socket, not VgLogTo_Fd, finalize_sink_fd should close it.
    
    Also close socket when connecting fails in VG_(connect_via_socket).
    
    Add a testcase for --log-file and --xml-file which prints output to
    /dev/stderr
    
    https://bugs.kde.org/show_bug.cgi?id=202770
    https://bugs.kde.org/show_bug.cgi?id=311655
    https://bugs.kde.org/show_bug.cgi?id=488379
    
    Co-authored-by: Alexandra Hájková <aha...@re...
    (cherry picked from commit fbd7596f8342f0b0fbbe088d960da839a8bdb839)

commit 0ced5269236c527d2e288b773e3684b6b1673ec2
Author: Mark Wielaard <ma...@kl...>
Date:   Mon Jun 17 00:27:12 2024 +0200

    Close both internal pipe fds after VG_(fork) in parent and child
    
    An VG_fork() creates a pipe between parent and child to syncronize the
    two processes. The parent wants to register the child pid before the
    child can run. This is done in register_sigchld_ignore.
    
    Make sure both the parent and the child close both the read and write
    file descriptors so none leak.
    
    https://bugs.kde.org/show_bug.cgi?id=479661
    (cherry picked from commit 1263471efdf8405cb0f1a767c6af73bf2eaf7160)

commit 2272233d23a5431e14b3c9385d2b4b66e0e8f0fd
Author: Alexandra Hájková <aha...@re...>
Date:   Thu Jun 20 07:45:56 2024 -0400

    Don't allow programs calling fnctl on valgrind's own file descriptors
    
    Add a call to ML_(fd_allowed) in the PRE handler of fcntl and fcntl64
    and block syscalls with EBADF when the file descriptor isn't allowed
    to be used by the program.
    
    https://bugs.kde.org/show_bug.cgi?id=337388
    (cherry picked from commit 4b83e3d47daaf5eff2ca96867a8c790e13830eb5)