Re: [Valgrind-users] Regression w.r.t. 1.0.3?

[<jhr...@t-...>]

----- Original Message -----
From: "Nicholas Nethercote" <nj...@ca...>
To: "Sebastian Kaliszewski" <sk@z.pl>
Cc: <val...@li...>
Sent: Sunday, August 03, 2003 9:53 PM
Subject: Re: [Valgrind-users] Regression w.r.t. 1.0.3?


> On Sun, 3 Aug 2003, Sebastian Kaliszewski wrote:
>
> > Wouldn't be that a good idea to allow for command line switch to turn
on/off
> > particular CPUID flags?
>
> Er, probably.

That would be great.

> In the meantime, you can workaround it by copying the old implementation
> of CPUID into the new version of Valgrind and recompiling (from
> vg_helpers.S in 1.0.3 --> coregrind/vg_helpers.S in the latest version,
> IIRC).

Tom Hughes sent the correct patch already:

--- vg_helpers.S.orig      2003-06-23 08:10:59.000000000 +0100
+++ vg_helpers.S        2003-08-03 16:33:48.000000000 +0100
@@ -135,12 +135,20 @@
        pushl   %edx
        movl    32(%esp), %eax

+       cmpl    $1, %eax
+       je      cpuid_nosse
+
         cmpl   $0x80000001, %eax
         je     cpuid_no3dnow

        cpuid
        jmp     cpuid__99

+cpuid_nosse:
+       cpuid
+       andl    $0xf9ffffff, %edx
+       jmp     cpuid__99
+
 cpuid_no3dnow:
        cpuid

Thanks,
Joerg