|
From: Paul F. <pj...@wa...> - 2023-04-26 11:58:14
|
On 26-04-23 12:32, Nicholas Nethercote wrote: > > > As I understand it, there are two main objections to mass-reformatting. > > * It breaks `git blame`. But as we've seen, this is entirely fixable. > * "If it ain't broken, don't fix it." But I argue that it the current > inconsistent formatting is a form of brokenness. Of course some care > is required to fix it, e.g. the particular style should be chosen > with care, and diffs should be reviewed by humans and not just > blindly accepted. But there are high-quality, widely-used tools that > make it straightforward. We should use them. Hi Nick I'm much more in favour if the git blame history is maintained. Wrong indentation can be a source of errors. I haven't seen any in the Valgrind source, but more often these days I see "python++" code (C or C++ code that looks like Python). This is the one place where you need to be careful reviewing the diffs. (clang-tidy nags about this as well). A+ Paul |