|
From: Paul F. <pj...@wa...> - 2023-04-22 19:22:29
|
On 22-04-23 19:44, Mark Wielaard wrote: > > But why do you want to reformat all the exiting code? > Isn't it enough if people have easy tools to format new hunks? > > I am happy if we encourage people to use code formatters for > new/changed code. But forcing a reformat of the whole project on > people seems like a bad idea. > > I think Paul's recent accident with clang-format shows why it is not a > good idea to try to reformat any existing code. It just introduces > huge arbitrary changes. The main thing for me is that the current indentation isn't too bad. Things like line breaks, continuation, align with assignment, multiple statements on a line are less consistent. That also means bigger diffs if reformatting. I wasn't expecting the diffs to be so big. For now I don't see enough benefit for large scale reformatting, but I am planning to continue using it for new blocks of code and new files. A+ Paul |