|
From: Paul F. <pj...@wa...> - 2023-04-22 19:09:33
|
On 22-04-23 16:35, Paul Floyd wrote:
>
>
> On 22-04-23 16:25, Mark Wielaard wrote:
>
>>
>> That is one giant patch. I assume accidential?
>> It also seems to break the build.
>> Could you please revert this (minus the NEWS typo).
>
> Yes I screwed up and pushed changes from experimenting with clang-format.
>
> Wonder how it broke the build - not very encouraging.
The error was
In file included from mc_main.c:49:
../include/pub_tool_xtmemory.h:41:38: error: unknown type name
‘XT_filter_IPs_t’
41 | extern void VG_(XTMemory_Full_init) (XT_filter_IPs_t
filter_IPs_Fn);
The compilation failure was because clang-format reordered all the
headers in mc_main.c into alphabetical order.
pub_tool_xtmemory.h has a dependency upon pub_tool_xtree.h but doesn't
include it and also pub_tool_xtree.h sorts alphabetically after
pub_tool_xtmemory.h which broke the dependency.
A+
Paul
|