|
From: Mark W. <ma...@kl...> - 2023-04-22 18:30:12
|
On Sat, Apr 22, 2023 at 09:53:22AM +1000, Nicholas Nethercote wrote: > Failing to add test files to Makefile.am is a really easy mistake to make, > and one I've done multiple times recently. Mark, you've often fixed these, > how do you detect them? I did a try push beforehand and it didn't detect > the missing file. There are two ways. make regtest does a quick check. Paul pointed out that can also be triggered by make post-regtest-checks. Maybe we should make that part of make check instead? The other is make distcheck. Which creates a dist and then tries to do a buid and make check (plus a srcdir != builddir build). The fedora-latest builder actually does a make distcheck, but since make auxchecks fails there it isn't in the try builders and doesn't show up as a new failure. I'll remove the auxchecks step and add it to the try builders. Cheers, Mark |