|
From: Mark W. <ma...@kl...> - 2023-04-22 16:13:46
|
Hi Tobias, On Sat, Apr 22, 2023 at 08:28:40AM +0200, Tobias Bading wrote: > Building c8832cb2d on Ubuntu (MATE) 20.04.6 LTS with gcc 9.4.0 > (Ubuntu 9.4.0-1ubuntu1~20.04.1) produces these 3 warnings: > > vgdb.c: In function ‘do_multi_mode’: > vgdb.c:1332:11: warning: ignoring return value of ‘asprintf’, declared > with attribute warn_unused_result [-Wunused-result] > 1332 | asprintf (&reply, > | ^~~~~~~~~~~~~~~~~ > […] > 1347 | "QSetWorkingDir+", (UInt)PBUFSIZ - 1); > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > vgdb.c: In function ‘fork_and_exec_valgrind’: > vgdb.c:1228:13: warning: ignoring return value of ‘write’, declared with > attribute warn_unused_result [-Wunused-result] > 1228 | write (pipefd[1], &err, sizeof (int)); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > vgdb.c:1283:7: warning: ignoring return value of ‘write’, declared with > attribute warn_unused_result [-Wunused-result] > 1283 | write (pipefd[1], &err, sizeof (int)); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Thanks for reporting. We are in trouble if these calls to asprintf or write fail and cannot do much more than exit at that point. But I fixed all three places so to explicitly check if those calls fail. > 8 bits of contribution in NEWS: > > - from different terminals. So for example to start you program > + from different terminals. So for example to start your program Thanks. Paul already fixed this. Cheers, Mark |