|
From: Nicholas N. <n.n...@gm...> - 2023-04-21 23:52:11
|
An interesting failure mode here: I actually did a try push for the commits that introduced this XML error. After try-pushing, I waited, then got some "tests succeeded" emails, and so I figured I was good to go and did the master-push. And then shortly after that I got some "tests failed" emails for different platforms. First, it's surprising that this XML problem was detected on some platforms but not others. Is the reason for this known? It seems sub-optimal. Also, is it possible to make this mistake harder/impossible to make? E.g. a single email with all the results, rather than multiple emails that arrive at different times. Failing that, at least the README_DEVELOPERS file could be clearer, it currently says this: > When all builders have build your patch the buildbot will sent you (or actually the patch author) > an email telling you if any builds failed and references to all the logs. Perhaps looking at https://builder.sourceware.org/buildbot/#/builders?tags=valgrind-try should be preferred to relying on the emails? It's frustrating that I tried to do the right thing here and still got it wrong. Stronger protections would be helpful. Nick On Fri, 21 Apr 2023 at 23:02, Nicholas Nethercote <nj...@so...> wrote: > > https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=b12703598ab42d377c3ecedc71f2e1324d932cd2 > > commit b12703598ab42d377c3ecedc71f2e1324d932cd2 > Author: Nicholas Nethercote <n.n...@gm...> > Date: Fri Apr 21 23:00:39 2023 +1000 > > Fix two xmllint errors. > > Diff: > --- > cachegrind/docs/cg-manual.xml | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/cachegrind/docs/cg-manual.xml b/cachegrind/docs/cg-manual.xml > index 35d6a412e3..a14cd7c926 100644 > --- a/cachegrind/docs/cg-manual.xml > +++ b/cachegrind/docs/cg-manual.xml > @@ -1065,8 +1065,6 @@ Cachegrind-specific options are: > <sect1 id="cg-manual.mergeopts" xreflabel="cg_merge Command-line Options"> > <title>cg_merge Command-line Options</title> > > -Although cg_merge is deprecated, its options are listed here for > completeness. > - > <!-- start of xi:include in the manpage --> > <variablelist id="cg_merge.opts.list"> > > @@ -1091,8 +1089,6 @@ Although cg_merge is deprecated, its options are > listed here for completeness. > <sect1 id="cg-manual.diffopts" xreflabel="cg_diff Command-line Options"> > <title>cg_diff Command-line Options</title> > > -Although cg_diff is deprecated, its options are listed here for > completeness. > - > <!-- start of xi:include in the manpage --> > <variablelist id="cg_diff.opts.list"> > > > _______________________________________________ > Valgrind-developers mailing list > Val...@li... > https://lists.sourceforge.net/lists/listinfo/valgrind-developers > |